Re: [libvirt PATCH 00/38] Refactor XML parsing boilerplate code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2021-03-18 at 16:03 +0100, Michal Privoznik wrote:
> On 3/18/21 9:00 AM, Tim Wiederhake wrote:
> > (...)
> >   10 files changed, 314 insertions(+), 663 deletions(-)
> > 
> 
> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> 
> Nice cleanup!
> 
> And if you agree with my suggestions in 01-02/38 (suggestion from 02 
> affects also 03), I can squash the changes in and push.
> 
> Michal

Thanks for the review!

Don't push it yet, I found one more "virTristateBoolTypeFromString"
that can be changed and that I missed somehow. I will add that to the
series, rebase, incorporate your suggestions, and resend tomorrow.

My plan is to do something similar for the "int-like" attributes next.

Cheers,
Tim




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux