Re: [libvirt PATCH 01/38] virStorageAdapterFCHost: Fix comment

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 3/18/21 9:00 AM, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@xxxxxxxxxx>
> ---
>   src/conf/storage_adapter_conf.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conf/storage_adapter_conf.h b/src/conf/storage_adapter_conf.h
> index 4c7da7c8d9..93879acb6e 100644
> --- a/src/conf/storage_adapter_conf.h
> +++ b/src/conf/storage_adapter_conf.h
> @@ -51,7 +51,7 @@ struct _virStorageAdapterFCHost {
>       char *parent_fabric_wwn;
>       char *wwnn;
>       char *wwpn;
> -    int managed;        /* enum virTristateSwitch */
> +    int managed;        /* enum virTristateBool */
>   };
>   
>   typedef struct _virStorageAdapter virStorageAdapter;

I'd expand the commit message a bit, like this:

    virStorageAdapterFCHost: Fix comment for @managed

    The enum that's used for @managed is virTristateBool and not
    virTristateSwitch as the comment says.


Michal