Re: [libvirt PATCH v2 4/6] ci: Introduce a util module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2021-03-17 at 12:02 +0100, Andrea Bolognani wrote:
> On Tue, 2021-03-16 at 18:32 +0100, Erik Skultety wrote:
> > +    apistr = str(api_version)
> > +    project_uri = f"{gitlab_uri}/api/v{apistr}/projects/{namespace_urlenc}"
> 
> Can't you use api_version without explicitly casting/converting it to
> a string here? It seems to work.

Actually, considering that our code only really speaks v4 API, it
would make perfect sense to drop the api_version argument altogether
and hardcode "v4" in the returned URI.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux