On Fri, Mar 12, 2021 at 06:28:12PM +0100, Andrea Bolognani wrote: > Changes from [v2]: > > * address review feedback; > > * wrap more Makefile functionality; > > * split into smaller, easier to review patches. > > Changes from [v1]: > > * implement (partial) support for running builds and spawning > shells inside the container; > > * make the code more maintainable by using a couple of classes. > > > [v2] https://listman.redhat.com/archives/libvir-list/2021-February/msg00922.html > [v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00900.html See my comments on a few of the patches, but overall, I like this, so: Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>
