Re: [libvirt PATCH v2 0/4] qemu: Only raise memlock limit if necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/9/21 2:47 PM, Andrea Bolognani wrote:
This feature has been requested by KubeVirt developers and will make
it possible for them to make some VFIO-related features, such as
migration and hotplug, work correctly.

   https://bugzilla.redhat.com/show_bug.cgi?id=1916346

Changes from [v1]:

   * prep patches have been pushed;

   * parsing /proc file is now explicitly restricted to Linux only
     and only uses safe libvirt helpers;

   * the qemu.conf knob has been dropped in favor of adopting a
     behavior that should work correctly in all scenarios.

[v1] https://listman.redhat.com/archives/libvir-list/2021-March/msg00293.html

Andrea Bolognani (4):
   util: Try to get limits from /proc
   qemu: Don't ignore virProcessGetMaxMemLock() errors
   qemu: Refactor qemuDomainAdjustMaxMemLock()
   qemu: Only raise memlock limit if necessary

  src/qemu/qemu_domain.c |  36 +++++++++------
  src/util/virprocess.c  | 102 +++++++++++++++++++++++++++++++++++++++++
  2 files changed, 125 insertions(+), 13 deletions(-)


If you fix small nits in 1/4 then:

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux