Re: [PATCH] meson: tools: depend on keycode generated sources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Friday in 2021, Andrea Bolognani wrote:
On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote:
On a Wednesday in 2021, Roman Bogorodskiy wrote:
> +keycode_dep = declare_dependency(sources: keycode_gen_sources)

Please format this as:

keycode_dep = declare_dependency(
   sources: keycode_gen_sources
)

to match the prevailing style.

Small correction: it should be

 keycode_dep = declare_dependency(
   sources: keycode_gen_sources,
 )

Note the additional comma, which allows us to have cleaner diffs when
making further changes, and the indentation being only two spaces
instead of three.

The three spaces come from your MUA misquoting me. I see two spaces in
my version of the e-mail, as well as the list archive:
https://listman.redhat.com/archives/libvir-list/2021-March/msg00252.html

(Not that my MUA is any better in that regard - the indentation in my
quoting of Roman's patch is wrong too)

Jano


--
Andrea Bolognani / Red Hat / Virtualization

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux