On Mon, Jan 11, 2021 at 12:50:02 +0300, Nikolay Shirokovskiy wrote:
> Now only qemu and test drivers support iotunes and for both of them this check
> makes sense. I guess there is little chance that this patch will break loading
> of some domains with incorrect config though. If this is the issue then we can
> put this common check to a different place.
>
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> ---
> src/conf/domain_conf.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 173424a..800bca5 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -8663,6 +8663,35 @@ virDomainBlockIoTuneValidate(virDomainBlockIoTuneInfoPtr iotune)
> return -1;
> }
>
> +#define CHECK_MAX(val) \
As noted for previous patch, this series is meant to remove macros, not
add them.
Add an open-coded version.
> + do { \
> + if (iotune->val##_max) { \
> + if (!iotune->val) { \
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, \
> + _("value '%s' cannot be set if " \
> + "'%s' is not set"), \
And don't break error messages.
