Re: [PATCH 01/23] qemu: pass supportGroupNameOption as expected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 11, 2021 at 12:49:54 +0300, Nikolay Shirokovskiy wrote:
> supportGroupNameOption was originally passed before the below patch. To solve
> the issue of that patch this change is not necessary and it make sense to
> pass supportGroupNameOption because of qemuMonitorSetBlockIoThrottle
> signature.
>
> With patch group_name is passed to qemu if disk in iotune group but group
> is not passed explicitly in parametes. For qemu it does not make a difference.

We always set all the fields in qemu, so arguably this is fixing the
behaviour also for the group name.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux