Hi guys, I marked this series as RFC to discuss some points. I'm interested in enhancing this specific part of LXC. So, some questions that I would like to hear as a feedback from community: 1. I decided to use a tar to compress all CRIU img files into a single file. Any other suggestions? 2. If no is the answer to question above, is there a consensus on preferring to use command line calls or libraries? I would like to use libtar for instance. I personally think that this approach is ugly. Not sure if I'm able to do that. The same for CRIU. 3. Other important opinions obviously. -- Julio Cesar Faracco Em sáb., 27 de fev. de 2021 às 01:06, Julio Faracco <jcfaracco@xxxxxxxxx> escreveu: > > This patch series implements a way to do checkpoint/restore to LXC driver using > CRIU operations. This respects the other methods to save and restore processes > states: using a file with a header with some metadata. The only difference here > is basically the way LXC drivers join the files produced by CRIU. CRIU generates > a lots of 'img' files and it is compresses using TAR to fit into the libvirt > state file. > > Julio Faracco (3): > meson: Add support to CRIU binary into meson > lxc: Including CRIU functions and functions to support C/R. > lxc: Adding support to LXC driver to restore a container > > meson.build | 10 + > meson_options.txt | 1 + > src/lxc/lxc_conf.c | 3 + > src/lxc/lxc_conf.h | 2 + > src/lxc/lxc_container.c | 188 +++++++++++++++++- > src/lxc/lxc_container.h | 3 +- > src/lxc/lxc_controller.c | 93 ++++++++- > src/lxc/lxc_criu.c | 405 +++++++++++++++++++++++++++++++++++++++ > src/lxc/lxc_criu.h | 50 +++++ > src/lxc/lxc_driver.c | 341 +++++++++++++++++++++++++++++++- > src/lxc/lxc_process.c | 26 ++- > src/lxc/lxc_process.h | 1 + > src/lxc/meson.build | 2 + > 13 files changed, 1106 insertions(+), 19 deletions(-) > create mode 100644 src/lxc/lxc_criu.c > create mode 100644 src/lxc/lxc_criu.h > > -- > 2.27.0 >
