On Thu, Feb 11, 2021 at 02:44:37PM -0600, Eric Blake wrote: > Supporting '0x20M' looks odd, particularly since we have a 'B' suffix > that is ambiguous for bytes, as well as a less-frequently-used 'E' > suffix for extremely large exibytes. In practice, people using hex > inputs are specifying values in bytes (and would have written > 0x2000000, or possibly relied on default_suffix in the case of > qemu_strtosz_MiB), and the use of scaling suffixes makes the most > sense for inputs in decimal (where the user would write 32M). But > rather than outright dropping support for hex-with-suffix, let's > follow our deprecation policy. Sadly, since qemu_strtosz() does not > have an Err** parameter, and plumbing that in would be a much larger > task, we instead go with just directly emitting the deprecation > warning to stderr. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > docs/system/deprecated.rst | 8 ++++++++ > util/cutils.c | 10 +++++++++- > 2 files changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
