[PATCH python] iothread: fix memory access out of bounds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: suruifeng <suruifeng@xxxxxxxxxx>

When the 'pcpu' is larger then the last 'iothr->cpumap' bits,
set the list element to False to avoid out of bounds access
'iothr->cpumap'.

Signed-off-by: suruifeng <suruifeng@xxxxxxxxxx>
Reviewed-by: Hogan Wang <hogan.wang@xxxxxxxxxx>

---
 libvirt-override.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/libvirt-override.c b/libvirt-override.c
index 1f55864..b099f51 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -1625,10 +1625,14 @@ libvirt_virDomainGetIOThreadInfo(PyObject *self ATTRIBUTE_UNUSED,
         VIR_PY_TUPLE_SET_GOTO(iothrtpl, 1, iothrmap, cleanup);
 
         for (pcpu = 0; pcpu < cpunum; pcpu++)
-            VIR_PY_LIST_SET_GOTO(iothrmap, pcpu,
-                                 PyBool_FromLong(VIR_CPU_USED(iothr->cpumap,
-                                                              pcpu)),
-                                 cleanup);
+            if (VIR_CPU_MAPLEN(pcpu + 1) > iothr->cpumaplen) {
+                VIR_PY_LIST_SET_GOTO(iothrmap, pcpu, PyBool_FromLong(0), cleanup);
+            } else {
+                VIR_PY_LIST_SET_GOTO(iothrmap, pcpu,
+                                     PyBool_FromLong(VIR_CPU_USED(iothr->cpumap,
+                                                                  pcpu)),
+                                     cleanup);
+            }
     }
 
     py_retval = py_iothrinfo;
-- 
2.23.0





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux