On Wed, Feb 03, 2021 at 11:39:05AM -0600, Jonathon Jongsma wrote: > This new API function provides a way to start a persistently-defined > mediate device that was defined by virNodeDeviceDefineXML() (or one that > was defined externally via mdevctl) > > Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > --- ... > +int nodeDeviceCreate(virNodeDevicePtr device) > +{ > + int ret = -1; > + virNodeDeviceObjPtr obj = NULL; > + virNodeDeviceDefPtr def; ...actually, please initialize ^this pointer as well to remain consistent. Erik (The RB still stands)