On Thu, Feb 11, 2021 at 16:37:58 +0100, Peter Krempa wrote: > For incremental backup we need QEMU_CAPS_BLOCKDEV, > QEMU_CAPS_BLOCKDEV_REOPEN, QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_capabilities.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index 38555dde98..7cc2532954 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -5164,8 +5164,10 @@ virQEMUCapsInitQMPVersionCaps(virQEMUCapsPtr qemuCaps) > void > virQEMUCapsInitProcessCapsInterlock(virQEMUCapsPtr qemuCaps) > { > - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) > - virQEMUCapsClear(qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP); > + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV) && > + virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV_REOPEN) && > + virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING)) > + virQEMUCapsSet(qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP); > > if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_STORAGE) && > !virQEMUCapsGet(qemuCaps, QEMU_CAPS_USB_STORAGE_WERROR)) { Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>