On Tue, Feb 16, 2021 at 09:46:42AM +0100, Peter Krempa wrote: > On Mon, Feb 15, 2021 at 19:20:25 +0100, Pavel Hrdina wrote: > > On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote: > > > The -2 value is misleading because if 'qemuAgentFSFreeze' fails it > > > doesn't necessarily mean that the command was sent to the agent. > > > > > > Since callers don't care about the -2 value specifically, remove it. > > > > In addition this indirectly fixes virDomainFSFreeze public API where > > we return result of qemuSnapshotFSFreeze directly. Now we comply with > > the API description. > > Luckily -2 happens only internally, so we never broke any public API > promise: > > This is caused by virNetServerProgramDispatchCall treating any negative > value as error and transporting it over RPC and then > virNetClientProgramCall in the client returning -1 if the returned reply > is of VIR_NET_ERROR type. Well, lucky for us :) I did not count RPC and the fact that even local connection will use remote driver for QEMU. Pavel
Attachment:
signature.asc
Description: PGP signature
