Re: [PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote:
> The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
> doesn't necessarily mean that the command was sent to the agent.
> 
> Since callers don't care about the -2 value specifically, remove it.

In addition this indirectly fixes virDomainFSFreeze public API where
we return result of qemuSnapshotFSFreeze directly. Now we comply with
the API description.

> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/qemu/qemu_snapshot.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux