> > Almost identical XML parsing code for either strings or files was copied > > 15 times. Since it was needed on two other places for parsing CPU XML > > strings with correct error reporting, I decided to factor the parsing code > > out to xml.c and used this one implementation in all other places. > > looking very quickly, this looks sensible, but I can't fully review > this right now, ACK on principle though, maybe this can wait for 0.7.8. In fact, the only visible change made by this patch set is better error reporting when XML passed to virConnectBaselineCPU and virConnectCompareCPU are not well-formed. So I guess it can wait for 0.7.8. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list