Re: [libvirt PATCH 4/4] ci: Drop the prepare.sh script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2021-02-10 at 18:00 +0100, Erik Skultety wrote:
> The purpose of this script was to prepare a customized environment in
> the container, but was actually never used and it required the usage of
> sudo to switch the environment from root's context to a regular user's
> one.
> The thing is that once someone needs a custom script they would very
> likely to debug something and would also benefit from root privileges
> in general, so the usage of 'sudo' in such case was a bit cumbersome.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  ci/prepare.sh | 13 -------------
>  1 file changed, 13 deletions(-)
>  delete mode 100644 ci/prepare.sh

This makes IMHO more sense either as 3/4 or even squashed directly
into 2/4.

Either way,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux