Re: [PATCH 04/19] virDomainMigrateVersion3Full: Don't set 'cancelled' to the same value

[Jiri Denemark <jdenemar@xxxxxxxxxx>]

On Thu, Feb 11, 2021 at 16:37:43 +0100, Peter Krempa wrote:
> It's already initialized to '1'.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/libvirt-domain.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index dba89a7d3a..e9688a15b4 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -3089,7 +3089,6 @@ virDomainMigrateVersion3Full(virDomainPtr domain,
>              virTypedParamsReplaceString(&params, &nparams,
>                                          VIR_MIGRATE_PARAM_URI,
>                                          uri_out) < 0) {
> -            cancelled = 1;
>              virErrorPreserveLast(&orig_err);
>              goto finish;
>          }
> @@ -3098,7 +3097,6 @@ virDomainMigrateVersion3Full(virDomainPtr domain,
>                                         VIR_MIGRATE_PARAM_URI, &uri) <= 0) {
>          virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>                         _("domainMigratePrepare3 did not set uri"));
> -        cancelled = 1;
>          virErrorPreserveLast(&orig_err);
>          goto finish;
>      }

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>