Signed-off-by: Jakob Meng <jakobmeng@xxxxxx>Thanks for the review! Feel free to drop or change the URLs, e.g. to permalinks:
https://gitlab.com/libvirt/libvirt/-/blob/f209d40a7e74e7e53a02c0c7ed20be218d390754/src/rpc/virnetsocket.c#L941 https://gitlab.com/libvirt/libvirt/-/blob/f209d40a7e74e7e53a02c0c7ed20be218d390754/src/rpc/virnetsocket.c#L1073 Jakob Am 05.02.21 um 12:52 schrieb Michal Privoznik:
On 1/29/21 1:55 PM, Jakob Meng wrote:Parameter 'known_hosts_verify' is supported for some time now, but it is not yet documented. Ref.:https://gitlab.com/libvirt/libvirt/-/blob/master/src/rpc/virnetsocket.c#L941 https://gitlab.com/libvirt/libvirt/-/blob/master/src/rpc/virnetsocket.c#L1073While these help with review I'd rather not put them into commit message because they are valid now, but as code shifts and move those lines might become stale. In fact, since the same code is in two places I think it should be de-duplicated. But that can be done in a follow up patch.However, you did not signed off your patch. We require patches to be signed off per https://libvirt.org/hacking.html#developer-certificate-of-originNo need to resend the patch, just reply to this e-mail with that line and I can amend it to the commit message and push.Michal
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
