Re: [PATCH] build: fix specfile logic for disabling netcf

[Laine Stump <laine@xxxxxxxxx>]

On 2/3/21 5:46 AM, Andrea Bolognani wrote:
> On Tue, 2021-02-02 at 13:05 -0500, Laine Stump wrote:
> > -%if 0%{?fedora} < 34 || 0%{?rhel} < 9
> > +%if (0%{?fedora} && 0%{?fedora} < 34) || (0%{?rhel} && 0%{?rhel} < 9)
> >       %define with_netcf 0%{!?_without_netcf:1}
> >   %endif
> You could also replace the existing
>
>    %define with_netcf 0
>
> that appears earlier in the file with
>
>    %define with_netcf 0%{!?_without_netcf:1}
>
> and rewrite this version check with
>
>    %if 0%{?fedora} > 33 || %{?rhel} > 8
>        %define with_netcf 0
>    %endif
>
> instead. This would keep the version check simpler.


I thought about that, but it would make the default be "enabled", and I 
want the default to be "disabled".