On Tue, Feb 02, 2021 at 05:55:40PM +0100, Peter Krempa wrote: > When virRandomBytes fails we don't get any random bytes and even if we > did they don't have to be treated as secret as they weren't used in any > way. > > Add a temporary variable with automatic freeing for the secret buffer > and assign it only on success. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
