Re: [PATCH v2 01/27] hypervFreeInvokeParams: Don't use VIR_DISPOSE_N for freeing 'params'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 02, 2021 at 05:55:38PM +0100, Peter Krempa wrote:
> The struct doesn't contain any secrets to clear before freeing and even
> if it did VIR_DISPOSE_N wouldn't help as the struct contains only
> pointers thus the actual memory pointing to isn't sanitized.
> 
> Just free the params array pointer and then the struct itself.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/hyperv/hyperv_wmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux