On Tue, Feb 02, 2021 at 01:05:04PM -0500, Laine Stump wrote:
> I *thought* I had tested all the combinations of manually setting
> --without netcf, different versions of Fedora, etc, but apparently
> not.
>
> The check in libvirt.spec.in to see if the target was an older Fedora
> or older RHEL would alway resolve to true, because, e.g., if {?fedora}
> is undefined, then "0%{?fedora} < 34" is "0 < 34", which is always
> true. Since both {?fedora} and {?rhel} are never defined at the same
> time, the result of the entire expression is always true.
>
> Fix this by qualifying each subexpression.
>
> Fixes: 35d5b26aa433bd33f4b33be3dbb67313357f97f9
> Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> ---
> libvirt.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
