Re: [libvirt PATCH 3/6] docs: introduces new vhostuser disk type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 03, 2021 at 10:21:37AM +0100, Peter Krempa wrote:
> On Tue, Feb 02, 2021 at 16:04:09 +0100, Pavel Hrdina wrote:
> >      <disk type='vhostuser' device='disk'>
> >        <driver name='qemu' type='raw'/>
> >        <source type='unix' path='/tmp/vhost-blk.sock' mode='client'>
> >          <reconnect enabled='yes' timeout='10'/>
> >        </source>
> >        <target dev='vda' bus='virtio'/>
> >      </disk>
> > 
> > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> > ---
> >  docs/formatdomain.rst         | 32 ++++++++++++++++++++++++++++++--
> >  docs/schemas/domaincommon.rng | 19 +++++++++++++++++++
> >  2 files changed, 49 insertions(+), 2 deletions(-)
> 
> Sorry for two replies, I've trimmed out too much in my first reply and
> didn't want to bother to undo it.

NP, I'll add the comment to documentation from the first reply, sounds
good.

> 
> > 
> > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> > index a09868bed5..99f5cad571 100644
> > --- a/docs/formatdomain.rst
> > +++ b/docs/formatdomain.rst
> > @@ -2419,6 +2419,13 @@ paravirtualized driver is specified via the ``disk`` element.
> >         </source>
> >         <target dev='vde' bus='virtio'/>
> >       </disk>
> > +     <disk type='vhostuser' device='disk'>
> > +       <driver name='qemu' type='raw'/>
> > +       <source type='unix' path='/tmp/vhost-blk.sock' mode='client'>
> 
> mode='client' is an example here ...

Nice catch, I'll remove it as this was part of my first approach.

Pavel

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux