On Tue, Feb 02, 2021 at 16:04:08 +0100, Pavel Hrdina wrote: > Make the function reusable by other vhost-user based devices. Since reusability is the goal ... > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > src/qemu/qemu_validate.c | 99 +++++++++++++++++++++------------------- > 1 file changed, 51 insertions(+), 48 deletions(-) > > diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c > index 88f4344df0..96fc7d4118 100644 > --- a/src/qemu/qemu_validate.c > +++ b/src/qemu/qemu_validate.c > @@ -1380,6 +1380,54 @@ qemuValidateDomainVirtioOptions(const virDomainVirtioOptions *virtio, > } > > > +static int > +qemuValidateDomainDefVhostUserRequireSharedMemory(const virDomainDef *def, > + const char *name, > + virQEMUCapsPtr qemuCaps) ... please document the semantics of the function. > +{ > + const char *defaultRAMId = virQEMUCapsGetMachineDefaultRAMid(qemuCaps, > + def->virtType,