Re: [PATCH 0/9] reduce code duplication in NodeDevice driver

[Ján Tomko <jtomko@xxxxxxxxxx>]

On a Monday in 2021, Daniel Henrique Barboza wrote:
> Hi,
>
> This series reduces code duplication between qemu_driver.c and
> libxl_driver.c by adding common code, related to NodeDevicePtr
> driver functions, into helper functions in domain_driver.c.
>
> No functional change was made.
>
>
> Daniel Henrique Barboza (9):
>  qemu, libxl, hypervisor: use virDomainDriverNodeDeviceReset() helper
>  datatypes.h: register AUTOPTR_CLEANUP_FUNC for virNodeDevicePtr
>  domain_driver.c: use g_auto* in virDomainDriverNodeDeviceReset()
>  qemu, libxl, hypervisor: use virDomainDriverNodeDeviceReAttach()
>    helper
>  domain_driver.c: use g_auto* in virDomainDriverNodeDeviceReAttach()
>  libxl_driver.c: validate 'driverName' earlier in
>    libxlNodeDeviceDetachFlags()
>  qemu_driver.c: validate 'driverName' earlier in
>    qemuNodeDeviceDetachFlags()
>  qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags()
>    helper
>  domain_driver.c: use g_auto* in virDomainDriverNodeDeviceDetachFlags()
>
> src/datatypes.h                |   2 +
> src/hypervisor/domain_driver.c | 147 +++++++++++++++++++++++++++++
> src/hypervisor/domain_driver.h |  11 +++
> src/hypervisor/meson.build     |   1 +
> src/libvirt_private.syms       |   3 +
> src/libxl/libxl_driver.c       | 164 +++------------------------------
> src/qemu/qemu_driver.c         | 164 ++++-----------------------------
> 7 files changed, 192 insertions(+), 300 deletions(-)

To what is in here:
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

But before this series is merged, a change to the list of files for
checking ACL calls is needed.

Jano

Attachment: signature.asc
Description: PGP signature