On Wed, Feb 24, 2010 at 08:11:45AM -0700, Eric Blake wrote: > According to Diego Elio Pettenò on 2/24/2010 8:04 AM: > > Check the host string before deciding whether to look for windres or not. > > dnl Look for windres to build a Windows icon resource. > > -AC_CHECK_TOOL([WINDRES], [windres], [no]) > > -AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != "no"]) > > +case "$host" in > > + *cygwin* | *mingw* ) > > + AC_CHECK_TOOL([WINDRES], [windres], []) > > + ;; > > +esac > > + > > +AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != ""]) > > I like the idea. However, shouldn't you also guarantee that WINDRES is > set even if $host is not windows-based, so that an inherited $WINDRES in a > Linux environment does not cause spurious triggering of the AM_CONDITIONAL? I'd argue the reverse, so users can set WINDRES in the environment before running configure, no? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list