Re: [PATCH 00/12] Hyper-V serial ports, NICs, and screeshots

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 1/22/21 9:18 PM, Matt Coleman wrote:
> This patchset makes the following changes to the Hyper-V driver:
> * enable XML parsing and creation of serial ports and NICs
> * implement several networking APIs
> * implement screenshots
>
> Matt Coleman (12):
>    hyperv: XML parsing of serial ports
>    hyperv: add support for creating serial devices
>    hyperv: XML parsing of Ethernet adapters
>    hyperv: add support for creating network adapters
>    hyperv: implement connectListAllNetworks and connectNumOfNetworks
>    hyperv: implement networkLookupByName and networkLookupByUUID
>    hyperv: implement connectNumOfDefinedNetworks and
>      connectListDefinedNetworks
>    hyperv: implement networkGetAutostart, networkIsActive, and
>      networkIsPersistent
>    hyperv: implement networkGetXMLDesc
>    hyperv: implement domainScreenshot
>    hyperv: provide a more detailed error message for WSMan faults
>    news: implement new Hyper-V APIs
>
>   NEWS.rst                              |  12 +
>   po/POTFILES.in                        |   1 +
>   src/hyperv/hyperv_driver.c            | 620 ++++++++++++++++++++++++++
>   src/hyperv/hyperv_network_driver.c    | 242 ++++++++++
>   src/hyperv/hyperv_network_driver.h    |  26 ++
>   src/hyperv/hyperv_wmi.c               |  45 +-
>   src/hyperv/hyperv_wmi.h               |  12 +
>   src/hyperv/hyperv_wmi_classes.h       |  36 ++
>   src/hyperv/hyperv_wmi_generator.input | 309 +++++++++++++
>   src/hyperv/meson.build                |   1 +
>   10 files changed, 1301 insertions(+), 3 deletions(-)
>   create mode 100644 src/hyperv/hyperv_network_driver.c
>   create mode 100644 src/hyperv/hyperv_network_driver.h

Looking good, but I have a few comments in 01/12 and 03/12.

Michal