Re: [PATCH] qemu: Replace deprecated short-form boolean options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Tue, Jan 26, 2021 at 6:04 PM Peter Krempa <pkrempa@xxxxxxxxxx> wrote:
On Tue, Jan 26, 2021 at 11:55:25 +0800, Han Han wrote:
> Since the commit ccd3b3b811 of QEMU, the short-form boolean options in
> qemu cmdline like "server", "nowait", "disable-ticketing" are deprecated:
>
> qemu-system-x86_64: -chardev socket,id=charmonitor,fd=38,server,nowait: warning: short-form boolean option 'server' deprecated
> Please use server=on instead
> qemu-system-x86_64: -chardev socket,id=charmonitor,fd=38,server,nowait: warning: short-form boolean option 'nowait' deprecated
> Please use wait=off instead
> qemu-system-x86_64: -spice port=5900,addr=127.0.0.1,disable-ticketing,plaintext-channel=main,plaintext-channel=inputs,image-compression=auto_glz,jpeg-wan-compression=auto,zlib-glz-wan-compression=auto,playback-compression=on,streaming-video=filter,disable-copy-paste,disable-agent-file-xfer,seamless-migration=on: warning: short-form boolean option 'disable-ticketing' deprecated
> Please use disable-ticketing=on instead
>
> Use normal form boolean options with value "on" or "off".
>
> Signed-off-by: Han Han <hhan@xxxxxxxxxx>
> ---

[...]

>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-both.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v2.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v3.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-both.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v2.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v3.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-full.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-partial.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-2.12.0.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-latest.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-console-native.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-serial+console-native.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-serial-compat.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/pci-rom-disabled-invalid.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-console-native.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-serial+console-native.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-serial-compat.args
>  mode change 120000 => 100644 tests/qemuxml2argvdata/user-aliases2.args

These files are expanded from a symlink to a full file. Did you use a
script/sed to do the changes? Preferably unless necessary don't expand
yes
those and use VIR_TEST_REGENERATE_OUTPUT=1  to generate them, that
doesn't expand symlinks.

Thank you. I'll fix that in the next version

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux