On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote: > On Fri, 2021-01-29 at 12:48 +0000, Daniel P. Berrangé wrote: > > On Wed, Jan 27, 2021 at 06:59:58PM +0100, Michal Privoznik wrote: > > > Since we've switched to meson our tests run with a timeout (meson > > > uses 30 seconds as the default). However, not every machine that > > > builds libvirt is fast enough to run every test under 30 seconds > > > (each test binary has its own timeout, but still). For instance > > > when building a package for distro on a farm that's under load. > > > Or on a generally slow ARM hardware. While each developer can > > > tune their command line for building by adding > > > --timeout-multiplier=10, this is hard to do for aforementioned > > > build farms. > > > > I don't get why it is hard for build farms. Someone, somwhere > > is writing the script that invokes meson & ninja with some > > args. Why is it hard to add --timeout-multiplier=10 too ? > > > > > It's time to admit that not everybody has the latest, top shelf > > > CPU and increase the timeout. > > > > I'm not convinced we want to optimize for the slowest hardware > > we can find, especially when there's an easy option of setting > > --timeout-multiplier=10. > > It's not complicated to add the option, but the fact that Debian, > SUSE and now Fedora all need to specify a timeout multiplier hints to > the fact that perhaps the default timeout is just too small. AFAIK, Fedora hasn't set any timeout multiplier in our builds. Some specific tests have an increased timeout, but that's reasonable because they are very big tests, and that's a targetted increase. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
