On 1/29/21 11:08 AM, Boris Fiuczynski wrote:
On 1/28/21 1:42 PM, Michal Privoznik wrote:
On 1/27/21 7:46 PM, Boris Fiuczynski wrote:
Add virtio related options iommu, ats and packed as driver element
attributes
to vsock devices. Ex:
<vsock model='virtio'>
<cid auto='no' address='3'/>
<driver iommu='on'/>
</vsock>
Signed-off-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx>
---
docs/formatdomain.rst | 2 +
docs/schemas/domaincommon.rng | 5 +++
src/conf/domain_conf.c | 34 +++++++++++++--
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c | 3 ++
src/qemu/qemu_validate.c | 3 ++
.../vhost-vsock-ccw-iommu.s390x-latest.args | 42 +++++++++++++++++++
.../vhost-vsock-ccw-iommu.xml | 33 +++++++++++++++
tests/qemuxml2argvtest.c | 1 +
.../vhost-vsock-ccw-iommu.s390x-latest.xml | 37 ++++++++++++++++
tests/qemuxml2xmltest.c | 2 +
11 files changed, 160 insertions(+), 3 deletions(-)
create mode 100644
tests/qemuxml2argvdata/vhost-vsock-ccw-iommu.s390x-latest.args
create mode 100644 tests/qemuxml2argvdata/vhost-vsock-ccw-iommu.xml
create mode 100644
tests/qemuxml2xmloutdata/vhost-vsock-ccw-iommu.s390x-latest.xml
Hi Michal,
thanks for your review.
The elements cpu and controller get autogenerated.
You are right that this does create a cross feature test.
Therefore your proposed change is a the correct thing to do.
Regarding your other two comments:
Do I understand you correctly that you accept the two changes as
pre-existing 'style' and will refactor these validations with a follow
up cleanup patch?
Yes, I've posted cleanup patches here:
https://www.redhat.com/archives/libvir-list/2021-January/msg01182.html
Now the only question is which patch is merged first :-) Anyway, I can
do the change locally before pushing your patch (if mine gets merged
earlier).
Basically, I only wanted you to confirm that you're okay with changes
I'm proposing.
Michal
