`val` is declared `ATTRIBUTE_NONNULL`. Found by clang-tidy's "clang-diagnostic-tautological-pointer-compare" check. Signed-off-by: Tim Wiederhake <twiederh@xxxxxxxxxx> --- src/util/vircommand.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index c3a98bbeac..223010c6aa 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1525,11 +1525,6 @@ virCommandAddArg(virCommandPtr cmd, const char *val) if (!cmd || cmd->has_error) return; - if (val == NULL) { - cmd->has_error = EINVAL; - return; - } - arg = g_strdup(val); /* Arg plus trailing NULL. */ -- 2.26.2