On Fri, Jan 22, 2021 at 03:01:57AM -0500, Laine Stump wrote: > Since libvirt.spec explicitly adds -Dnetcf=enabled to the meson > commandline, just setting the default in the meson.build file won't > have any effect for rpm builds. This patch changes the meson > commandline in the spec file to -Dnetcf=disabled and removes the > associated BuildRequires: and Requires: > > (I debated whether or not to do that conditionally only for (fedora > > 33 || rhel > 8) but haven't done that for now (still may if it's > considered important; for Fedora probably not important (since we > never rebase after release), for RHEL we might want to preserve > current behavior for RHEL8 even through a rebase though) Yeah, our normal policy is that we don't disable stuff that was already present. So changing this should be conditional on newer distros only. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
