According to Jim Meyering on 2/23/2010 10:06 AM: > Making all in po > make[2]: Entering directory `/w/co/libvirt/po' > make[2]: *** No rule to make target `/config.status', needed by `Makefile'. Stop > > I tracked that down to the fact that po/Makevars is now removed > (rightly so, since it's generated), and it contained the definition > of top_builddir, which when missing provokes the diagnostic above. Yes, I was encountering some of that yesterday, but wasn't sure how much of it was due to my (constantly-changing) setup while I was tweaking the gnulib bootstrap side of things. My testing passed only because I ended up doing a fresh checkout every time. > I propose to include the following change right after yours: > The only trick is to disable the new syntax-check for hash.h, > since it currently evokes a false-positive. Is there ever a chance that #include <hash.h> in libvirt sources will pick up the wrong header? That is, should we rename one of the two files to a less-common name, then update all clients to specify which of the two versions they are grabbing? But that is independent of this patch. > Subject: [PATCH] build: update gnulib submodule to latest > > * cfg.mk (local-checks-to-skip): Disable sc_prohibit_hash_without_use > for now, since it fails with a false-positive match. ACK (assuming my ACK is good for much, given my relative newcomer status). For that matter, maybe we should push yours first; the commit message in 3/4 can then use a bit of tweaking, if we then match bootstrap to ./.gnulib/build-aux/bootstrap. I guess I should also do a followup patch to README-hacking to give the hint about setting GNULIB_SRCDIR to reduce download time if you already have a local copy of gnulib.git. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list