On 1/15/21 11:12 AM, Michal Privoznik wrote:
Technically, this is v3 of: https://www.redhat.com/archives/libvir-list/2020-December/msg00199.html But I've split the big series (so no longer mixing virtio-mem and virtio-pmem). The virtio-pmem-pci is very similar to NVDIM so the implementation is fairly straightforward. Michal Prívozník (6): qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_PMEM_PCI conf: Introduce virtio-pmem <memory/> model security: Relabel virtio-pmem qemu: Allow virtio-pmem in CGroups qemu: Create virtio-pmem in namespace qemu: Build command line for virtio-pmem
Series LGTM. One more stuff to the "features that exists in x86_64 but not on PowerPC for no apparent reason" list :/ Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
docs/formatdomain.rst | 29 ++++-- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 41 ++++++++- src/conf/domain_conf.h | 3 +- src/conf/domain_validate.c | 40 ++++++++- src/qemu/qemu_alias.c | 58 ++++++++---- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 6 +- src/qemu/qemu_command.c | 73 ++++++++------- src/qemu/qemu_domain.c | 25 ++++++ src/qemu/qemu_domain_address.c | 88 +++++++++++++++---- src/qemu/qemu_domain_address.h | 3 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_namespace.c | 3 +- src/qemu/qemu_validate.c | 8 ++ src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + ...ory-hotplug-virtio-pmem.x86_64-latest.args | 45 ++++++++++ .../memory-hotplug-virtio-pmem.xml | 53 +++++++++++ tests/qemuxml2argvtest.c | 1 + ...mory-hotplug-virtio-pmem.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + 29 files changed, 414 insertions(+), 80 deletions(-) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-pmem.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-pmem.xml create mode 120000 tests/qemuxml2xmloutdata/memory-hotplug-virtio-pmem.x86_64-latest.xml