On Thu, Jan 14, 2021 at 14:15:17 +0100, Peter Krempa wrote: > Commit 154df5840d added support for <metadata_cache> as property of a > <disk>. Since the same parser is used to parse the XML used with > virDomainBlockCopy it starts the copy job with the appropriate cache > configured, but the <mirror> doesn't show this configuration nor it's > preserved if libvirtd is restarted during the mirror. > > Add parsing, formatting and tests for <metadata_cache> for a <mirror>. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > > Since <metadata_cache> was introduced in this release we should probably > fix this too prior to the release. Yeah, I think it makes sense to fix this bug in 7.0. After all, fixing and stabilizing what we did since the last release is the main point of the freeze period. Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
