Re: [PATCH] test-wrap-argv.py: Actually print filename of offending script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 13, 2021 at 06:42:40 -0300, Daniel Henrique Barboza wrote:
> 
> 
> On 1/12/21 3:51 PM, Peter Krempa wrote:
> > The error message doesn't actually print the filename of the offending
> > file:
> > 
> >   Incorrect line wrapping in %file
> > 
> > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> > ---
> >   scripts/test-wrap-argv.py | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/test-wrap-argv.py b/scripts/test-wrap-argv.py
> > index 6b0d3511f3..9ec572b479 100755
> > --- a/scripts/test-wrap-argv.py
> > +++ b/scripts/test-wrap-argv.py
> > @@ -137,8 +137,8 @@ def rewrap(filename, in_place, check):
> >                                       stdin=subprocess.PIPE)
> >               diff.communicate(input=new.encode('utf-8'))
> > 
> > -            print("Incorrect line wrapping in $file",
> > -                  file=sys.stderr)
> 
> Apparently my python is rusty. I would never tell that this would print
> 
> "Incorrect line wrapping in %file"

OOps, it does not. I've apparently copied from one of the outputs of
failed attempts to fix it :D

I've actually found one more mistake in scripts/group-qemu-caps.py so
I'll fix that one as well.

> 
> 
> 
> > +            print("Incorrect line wrapping in '%s'" %
> > +                  filename, file=sys.stderr)
> 
> 
> Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> 
> 
> >               print("Use test-wrap-argv.py to wrap test data files",
> >                     file=sys.stderr)
> >               return False
> > 
> 




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux