Re: [libvirt PATCH 1/2] gitlab-ci.yaml: Introduce a variable to disable long broken jobs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 11, 2021 at 03:56:03PM +0100, Erik Skultety wrote:
> On Mon, Jan 11, 2021 at 01:53:49PM +0000, Daniel P. Berrangé wrote:
> > On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> > > Unfortunately GitLab doesn't have a different mechanism on how to mark
> > > jobs as skipped or disabled apart from the 'only'/'except' pragmas.
> > > Use the 'except' pragma for the job templates to skip jobs which define
> > > the DISABLE_JOB variable.
> > 
> > What's wrong with using
> > 
> >    when: never  (or manual to let devs force it from the UI)
> > 
> 
> 'when: never' can only be used in conjunction with the 'rules' keyword [1],[2]
> which in turn is mutually exclusive with 'only/except' [3] which we currently
> utilize.

Gitlab recommends use of "rules" over "only/except", so we should
probably change that.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux