Re: [libvirt] [PATCH] Create raw storage files with O_DSYNC (again)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/22/2010 06:32 AM, Jiri Denemark wrote:
Recently we introduced O_DYSNC flag when creating raw storage files to
avoid filling all disk cache with dirty pages. However, the patch got
lost when virStorageBackendCreateRaw was reworked using
virFileOperation.

Oops! Sorry about that! I guess missed it when resolving conflicts of a rebase.

  Let's use O_DYSNC again.

Signed-off-by: Jiri Denemark<jdenemar@xxxxxxxxxx>
---
  src/storage/storage_backend.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index 8b9ed5d..3742493 100644
--- a/src/storage/storage_backend.c
+++ b/src/storage/storage_backend.c
@@ -356,7 +356,8 @@ virStorageBackendCreateRaw(virConnectPtr conn ATTRIBUTE_UNUSED,
          goto cleanup;
      }

-    if ((createstat = virFileOperation(vol->target.path, O_RDWR | O_CREAT | O_EXCL,
+    if ((createstat = virFileOperation(vol->target.path,
+                                       O_RDWR | O_CREAT | O_EXCL | O_DSYNC,
                                         vol->target.perms.mode,
                                         vol->target.perms.uid, vol->target.perms.gid,
                                         createRawFileOpHook,&hdata,

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]