On Mon, Jan 04, 2021 at 04:30:03PM +0100, Peter Krempa wrote:
> On Mon, Dec 14, 2020 at 16:55:24 +0100, Pavel Hrdina wrote:
> > The function doesn't take virStorageSource as argument and has nothing
> > in common with virStorageSource or storage file.
> >
> > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> > ---
> > src/libvirt_private.syms | 1 -
> > src/locking/lock_driver_lockd.c | 66 ++++++++++++++++++++++++++++++++-
> > src/util/virstoragefile.c | 62 -------------------------------
> > src/util/virstoragefile.h | 2 -
> > 4 files changed, 65 insertions(+), 66 deletions(-)
>
> [...]
>
> > +#ifdef LVS
> > +static int virLockManagerGetLVMKey(const char *path,
> > + char **key)
> > +{
>
> Preferably convert the header to the modern function header style where
> the function name starts on a new line after the type. (also in the
> #else section)
I opted to the old style because the majority of that file uses but I
guess there is no harm of using the modern style. I'll fix it before
pushing.
> > + /*
> > + * # lvs --noheadings --unbuffered --nosuffix --options "uuid" LVNAME
>
> Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
