Re: [libvirt PATCH 10/17] virstoragefile: move virStorageIsRelative into virfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 14, 2020 at 16:55:30 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/libvirt_private.syms  |  2 +-
>  src/qemu/qemu_block.c     |  2 +-
>  src/qemu/qemu_snapshot.c  |  2 +-
>  src/util/virfile.c        | 13 +++++++++++++
>  src/util/virfile.h        |  2 ++
>  src/util/virstoragefile.c | 15 +--------------
>  src/util/virstoragefile.h |  2 --
>  7 files changed, 19 insertions(+), 19 deletions(-)

NACK based on the same grounds as previous patch. This function is not
checking whether a file is relative, but just the filename. This is
relevant just to backing chain manipulation.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux