Re: [PATCHv3 0/3] Use netlink to create veth device pair when netlink is supported

[Laine Stump <laine@xxxxxxxxxx>]

On 12/16/20 1:01 AM, Shi Lei wrote:
> V2 here: https://www.redhat.com/archives/libvir-list/2020-November/msg01239.html
> Since V2:
>      * Remove the argument 'status' of virNetDevVethCreateInternal
>      * fix a memory leak in virLXCProcessSetupInterfaceTap
>
> V1 here: https://www.redhat.com/archives/libvir-list/2020-November/msg00898.html
> Since V1:
>      * Include <linux/veth.h> rather than introducing enum VETH_INFO_*
>      * Have complete functions within an #ifdefs rather than
>        putting #ifdefs in function
>
> Shi Lei (3):
>    util:netlink: Enable virNetlinkNewLink to support veth
>    util:veth: Create veth device pair by netlink
>    lxc: fix a memory leak
>
>   src/lxc/lxc_process.c    |   4 +-
>   src/util/virnetdevveth.c | 126 ++++++++++++++++++++++-----------------
>   src/util/virnetlink.c    |  14 +++++
>   src/util/virnetlink.h    |   1 +
>   4 files changed, 89 insertions(+), 56 deletions(-)
Reviewed-by: Laine Stump <laine@xxxxxxxxxx>


for all 3 (with one tiny change to patch 1 to fix build failure in 
mingw, MacOS and FreeBSD). They're pushed now.


Thanks!