On 12/14/20 5:57 PM, Ryan Gahagan
wrote:
On Thu, Dec 10, 2020 at 10:37 PM Han Han <hhan@xxxxxxxxxx> wrote:On Fri, Dec 11, 2020 at 4:00 AM Ryan Gahagan <rgahagan@xxxxxxxxxxxxx> wrote:
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 512939679b..40a1a3c1e2 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -2601,6 +2601,7 @@ paravirtualized driver is specified via the ``disk`` element.
sheepdog one of the sheepdog servers (default is localhost:7000) zero or one 7000
gluster a server running glusterd daemon one or more ( :since:`Since 2.1.0` ), just one prior to that 24007
vxhs a server running Veritas HyperScale daemon only one 9999
+ nfs a server running Network File System only one 2049
Mention the feature introduced version here.What version would we specify? QEMU's version 2.9.0 patch where they introduce NFS support? The Libvirt current version 6.10.0 patch? A future patch number (e.g. Libvirt version 6.11.0 or similar)? We were unclear on what exact number goes here, but we were planning on putting it into the space parallel to the :since: in the gluster line.
You would put the version that libvirt will be at when the
feature is in released code, so if it was pushed today, that would
be 7.0.0. (Sometimes we also indicate a minimum qemu or kernel
version that's required, which is more useful if a feature is just
newly supported in qemu/kernel but over time it just becomes
extra numbers to confuse people. In this case, my opinion would be
that the qemu version is old enough that it's not necessary to
mention it.)
