On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote: > On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote: > > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > > There's no generic way to query current accel and its properties via QOM > > > because there's no link between an accel and current machine. > > > > > > The change adds the link, i.e. if HVF is enabled the following will be > > > available in QOM: > > > > > > (qemu) qom-get /machine/accel type > > > "hvf-accel" > > > > > > Suggested-by: Markus Armbruster <armbru@xxxxxxxxxx> > > > Suggested-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > > Signed-off-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx> > > > --- > > > > > > Hi, > > > > > > this is a follow up patch that deprecates earlier series [1]. > > > > > > > Is there a reference to the reasoning for dropping the earlier > > approach? Your previous approach seems preferable. > > The gist of the discussion before was that deprecating old commands in > the same release cycle as introducing the replacement might be > problematic if libvirt wants to adapt ASAP and that the new command > should be elevated to a intermediate tier of stability, where ACK from > libvirt is needed to change it during the same release cycle > incompatibly. > > That was meant generally for any command, and was started because we had > a similar issue recently. > > My intention definitely was not to change the patch itself, but more a > process change so that we can keep cooperating on new stuff rapidly, but > without actually breaking what we do. > Thanks Peter, I'll drop deprecation patch in v2 of query-accel QMP command. Ragards, Roman
