Re: [PATCH 2/5] netdevtap: Use common helper function to create unique tap name

[Laine Stump <laine@xxxxxxxxxx>]

On 12/4/20 2:01 AM, Shi Lei wrote:
> Simplify GenerateName/ReserveName for netdevtap by using common
> functions.
>
> Signed-off-by: Shi Lei <shi_lei@xxxxxxxxxxxxxx>
> ---
>   src/util/virnetdevtap.c | 58 +++--------------------------------------
>   1 file changed, 4 insertions(+), 54 deletions(-)
>
> diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
> index 198607b5..38b2f171 100644
> --- a/src/util/virnetdevtap.c
> +++ b/src/util/virnetdevtap.c
> @@ -55,9 +55,6 @@


Also, I noticed when looking at patch 3 that you removed #include 
<math.h> due to pow() no longer being needed - I think you need to do 
that in this file too.


>   
>   VIR_LOG_INIT("util.netdevtap");
>