[libvirt PATCH] libvirt-guests: Remove obsolete Windows comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Kevin Locke <kevin@xxxxxxxxxxxxxxx>

The comment that

> For instance, qemu-ga doesn't support guest time synchronization on
> Windows guests, but Linux ones.

Was correct at the time, but has since been addressed by
qemu/qemu@105fad6bb22, which added support for set-time without a time
argument, as used by `virsh domtime --sync` by libvirt-guests.sh.  I can
confirm that `virsh domtime --sync` works correctly on a Windows 10
guest, as does `SYNC_TIME=1`.  (Note that there can be a significant
delay between when the command completes and when the guest time
finishes synchronizing due to QEMU GA calling `w32tm` with `/nowait`,
which complicates testing.)

Signed-off-by: Kevin Locke <kevin@xxxxxxxxxxxxxxx>
---

Merged this trivial docs patch from a gitlab MR.

 tools/libvirt-guests.sysconf | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf
index 0765efec21..4f83edab90 100644
--- a/tools/libvirt-guests.sysconf
+++ b/tools/libvirt-guests.sysconf
@@ -46,7 +46,5 @@
 
 # If non-zero, try to sync guest time on domain resume. Be aware, that
 # this requires guest agent with support for time synchronization
-# running in the guest. For instance, qemu-ga doesn't support guest time
-# synchronization on Windows guests, but Linux ones. By default, this
-# functionality is turned off.
+# running in the guest. By default, this functionality is turned off.
 #SYNC_TIME=1
-- 
2.28.0




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux