On Thu, 2020-12-03 at 22:05 -0300, Daniel Henrique Barboza wrote: > From: Andrea Bolognani <abologna@xxxxxxxxxx> > > The ppc64 tests > > memory-hotplug-ppc64-nonuma > memory-hotplug-nvdimm-ppc64 > > are not passed the same information for qemuxml2argv and > qemuxml2xml tests; the former, in particular, doesn't show up > at all in qemuxml2xml. Address this inconsistency. > > Note that one of the new output files had been introduced with > 5540acb9a2bd despite not being actually used as of that commit. > > Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx> > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > .../memory-hotplug-nvdimm-ppc64.args | 2 +- > ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 38 ---------------- > tests/qemuxml2argvtest.c | 4 +- > .../memory-hotplug-ppc64-nonuma.xml | 45 +++++++++++++++++++ > tests/qemuxml2xmltest.c | 5 +++ > 5 files changed, 54 insertions(+), 40 deletions(-) > delete mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.ppc64-latest.args > create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-ppc64-nonuma.xml I have now pushed this patch and the next one with your R-b as well as Jano's. -- Andrea Bolognani / Red Hat / Virtualization