On Wed, Feb 17, 2010 at 05:18:40PM +0000, Matthew Booth wrote: > On 17/02/10 17:08, Daniel Veillard wrote: > > Hum, virDomainDevicePCIAddressEqual is actually exposed in > > src/libvirt_private.syms so that would have to be cleaned up there too. > > If no ongoing patches is needing them I'm fine removeing those, > > Hadn't spotted that. Attached new patch which touches > src/libvirt_private.syms. > > Matt > -- > Matthew Booth, RHCA, RHCSS > Red Hat Engineering, Virtualisation Team > > M: +44 (0)7977 267231 > GPG ID: D33C3490 > GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 > >From 5612c7c7a5969a84cc97f50ad2bdf9070ef95210 Mon Sep 17 00:00:00 2001 > From: Matthew Booth <mbooth@xxxxxxxxxx> > Date: Wed, 17 Feb 2010 13:25:41 +0000 > Subject: [PATCH] Remove unused functions from domain_conf > > Remove virDomainDevicePCIAddressEqual and virDomainDeviceDriveAddressEqual, > which are defined but not used anywhere. > > * src/conf/domain_conf.[ch] > src/libvirt_private.syms: Remove virDomainDevicePCIAddressEqual and > virDomainDeviceDriveAddressEqual. > --- > src/conf/domain_conf.c | 24 ------------------------ > src/conf/domain_conf.h | 4 ---- > src/libvirt_private.syms | 1 - > 3 files changed, 0 insertions(+), 29 deletions(-) Okay, pushed, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list