Re: [PATCH v2 2/2] qemu: support logfile on live attaching chardev

Daniel Henrique Barboza <danielhb413@xxxxxxxxx> · Wed, 2 Dec 2020 10:55:16 -0300

On 12/2/20 9:25 AM, Nikolay Shirokovskiy wrote:
Currently it is simply ignored.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
---

Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>

  src/qemu/qemu_monitor_json.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index ff03a5a..0745717 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -7611,6 +7611,13 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID,
          goto cleanup;
      }
  
+    if (chr->logfile &&
+        virJSONValueObjectAdd(data,
+                              "s:logfile", chr->logfile,
+                              "T:logappend", chr->logappend,
+                              NULL) < 0)
+        goto cleanup;
+
      if (virJSONValueObjectAppendString(backend, "type", backend_type) < 0 ||
          virJSONValueObjectAppend(backend, "data", data) < 0)
          goto cleanup;








