Re: [libvirt PATCH] src: use singular form instead of plural, for guest disk info

Peter Krempa <pkrempa@xxxxxxxxxx> · Wed, 2 Dec 2020 13:20:23 +0100



On Wed, Dec 02, 2020 at 12:12:21 +0000, Daniel Berrange wrote:
> Existing practice with the filesystem fields reported for the
> virDomainGetGuestInfo API is to use the singular form for
> field names. Ensure the disk info follows this practice.
> 
> Fixes
> 
>   commit 05a75ca2ce743bc0bb119fb8d532ff84646fafa3
>   Author: Marc-AndrÃ© Lureau <marcandre.lureau@xxxxxxxxxx>
>   Date:   Fri Nov 20 22:09:46 2020 +0400
> 
>     domain: add disk informations to virDomainGetGuestInfo
> 
>   commit 0cb2d9f05d00497a715352f6ea28cf8fb6921731
>   Author: Marc-AndrÃ© Lureau <marcandre.lureau@xxxxxxxxxx>
>   Date:   Fri Nov 20 22:09:47 2020 +0400
> 
>     qemu_driver: report guest disk informations
> 
> Signed-off-by: Daniel P. BerrangÃ© <berrange@xxxxxxxxxx>
> ---
>  src/libvirt-domain.c   | 14 +++++++-------
>  src/qemu/qemu_driver.c | 14 +++++++-------
>  2 files changed, 14 insertions(+), 14 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>